Move codecov.yml into .github directory and increase coverage target to 90 percent#998
Move codecov.yml into .github directory and increase coverage target to 90 percent#998
Conversation
One less configuration file to see in the top level directory. See https://docs.codecov.io/docs/codecov-yaml#can-i-name-the-file-codecovyml
weiji14
added
maintenance
|
Just wondering, do we want to increase the target coverage from 80% to 90% (or higher)? We've been tracking at above 95% for the past six months it seems.
Lines 5 to 9 in f0a6a64 |
I'm fine with 90% or 95% coverage. |
weiji14
force-pushed
the
move-codecov-yml
branch
from
eabdd32 to
870704e
Compare
|
Ok, increased to 90%. Merging. |
weiji14
changed the title
|
I think we misunderstand what 90% means. We set the target of patches to 90%. I think it means at least 90% of the changed lines should be covered. It's different than the project coverage. If I understand it correctly, the project coverage only pass if the current coverage is no smaller than the previous coverage. |
Ah, so we need to set the project coverage as well then perhaps, in addition to the patch coverage? |
|
Maybe, but I didn't read the codecov documentation carefully. |
…to 90 percent (GenericMappingTools#998) * Move codecov configuration file into .github directory One less configuration file to see in the top level directory. See https://docs.codecov.io/docs/codecov-yaml#can-i-name-the-file-codecovyml * Increase code coverage target to 90%
2 participants
Description of proposed changes
One less configuration file to see in the top level directory.
See https://docs.codecov.io/docs/codecov-yaml#can-i-name-the-file-codecovyml
Helps with #904
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version